Skip to content

feat/bcrypt from maven#663

Merged
razvan merged 5 commits intomainfrom
feat/bcrypt-from-maven
May 10, 2024
Merged

feat/bcrypt from maven#663
razvan merged 5 commits intomainfrom
feat/bcrypt-from-maven

Conversation

@razvan
Copy link
Copy Markdown
Member

@razvan razvan commented May 8, 2024 •
edited
Loading

Description

NOTE: tested here: stackabletech/nifi-operator#616

Related: stackabletech/stackable-utils#71

  • Provision stackable-bcrypt from Maven
  • RUN must be on one line
  • Successfully built image

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Does your change affect an SBOM? Make sure to update all SBOMs
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan requested a review from soenkeliebau May 8, 2024 16:08
This was referenced May 10, 2024
Merged
Merged
@razvan razvan self-assigned this May 10, 2024
@razvan razvan enabled auto-merge May 10, 2024 11:15
maltesander
maltesander approved these changes May 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@razvan razvan added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit b544b6b May 10, 2024
@razvan razvan deleted the feat/bcrypt-from-maven branch May 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

@soenkeliebau soenkeliebau Awaiting requested review from soenkeliebau

Assignees

@razvan razvan

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@razvan @maltesander